ES|QL: Fix generative tests #129717
Merged
ES|QL: Fix generative tests #129717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>test
elasticsearchmachine
added
v9.1.0
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
approved these changes
Jun 19, 2025
luigidellaquila
removed
the
auto-merge-without-approval
ivancea
approved these changes
Jun 19, 2025
|
|
||
| if (previousOutput.size() > limit && output.size() != limit || defaultLimit && previousOutput.size() < output.size()) { | ||
| return new ValidationResult(false, "Expecting [" + limit + "] records, got [" + output.size() + "]"); | ||
| if (output.size() > limit) { |
Contributor
There was a problem hiding this comment.
Out of curiosity, which queries weren't deterministic in the number of rows?
Contributor
Author
There was a problem hiding this comment.
All the queries that have a very early LIMIT are very non-deterministic, eg.
FROM idx
| LIMIT 10
| WHERE <something>
| LIMIT 10
the WHERE condition receives very few (random) records, at every run I expect zero to ten (different) results.
This said, in the CI I found some very suspicious queries that I'm investigating now, but for the general case I don't think we can do better than this for now
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #129453